Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Progress towards #689
UI comm now accessible via
Console::ui_comm(). It returns an optional reference to a UI comm view with methods to send UI comm events or requests. If the option isNone, the UI comm is not connected. If it'sSome().The
Console::try_ui_comm()variant returns aResultand is nice for easy propagation of errors when the UI comm is expected.Since the UI comm is frontend-initiated, added
CommOpenplumbing. You were right to call out the complicated-looking factory handler, it was not necessary (and I can't think of a reason for it to be necessary with other comms).The continuation prompt field has been removed from
PromptInfo. We now refresh the prompt from thehandle_environment()comm method, and fetchgetOption("continue")from there.Fixes the busy/idle race condition, and makes the tests both simpler, more robust, and more exhaustive.